User assets migration #6038
Merged
User assets migration #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@benisgold/user-assets-refactor
…@benisgold/user-assets-refactor
…@benisgold/user-assets-refactor
…@benisgold/user-assets-migration-v2
…rainbow-me/rainbow into @benisgold/user-assets-migration-v2
benisgold
changed the base branch from
develop
to
@benisgold/user-assets-refactor
…rainbow-me/rainbow into @benisgold/user-assets-migration-v2
…@benisgold/user-assets-refactor
…rainbow-me/rainbow into @benisgold/user-assets-migration-v2
ibrahimtaveras00
requested changes
Sep 25, 2024
…@benisgold/user-assets-migration-v2
benisgold
force-pushed
the
@benisgold/user-assets-migration-v2
branch
from
a833689 to
153e842
Compare
…nt initial no assets state
…@benisgold/user-assets-migration-v2
|
@benisgold can you take a look at these conflicts? |
…@benisgold/user-assets-migration-v2
…@benisgold/user-assets-migration-v2
…@benisgold/user-assets-migration-v2
ibrahimtaveras00
approved these changes
Dec 17, 2024
…@benisgold/user-assets-migration-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1644, APP-1822
What changed (plus any additional context for devs)
Currently there is a mismatch between user assets within swaps and user assets elsewhere in the app because we have two different user assets queries. This PR migrates all usage of user assets over to the newer query located at
src/__swaps__/screens/Swap/resources/assets/userAssets.tsand removes usage of the old query (and related code) located atsrc/resources/assets/UserAssetsQuery.ts. The new user assets data is primarily accessed through theuserAssetsStore.Screen recordings / screenshots
What to test
will build a TF but having build issues rn
i encourage thorough testing of all features involving using assets including sends, swaps, wallet screen, change wallet sheet, wallet switching, persistence