nfts sort direction #6068

greg-schrammel · 2024-08-30T20:19:37Z

Fixes APP-####

What changed (plus any additional context for devs)

adds options to order asc/desc to collectibles

Screen recordings / screenshots

Screen.Recording.2024-09-10.at.12.55.55.mov

What to test

…ng-nfts-on-android-is-broken

linear · 2024-08-30T20:19:40Z

APP-1756 Sorting NFTs on Android is broken

socket-security · 2024-09-04T16:48:18Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	`0`	21.9 MB	typescript-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

…-broken

brunobar79 · 2024-09-10T18:36:39Z

Launch in simulator or device for 433c00c

src/components/cards/MintsCard/Menu.tsx

src/components/change-wallet/AddressRow.tsx

walmat · 2024-09-12T17:26:06Z

...creens/transaction-details/components/TransactionDetailsStatusActionsAndTimestampSection.tsx

+                {
+                  actionKey: 'cancel',
+                  actionTitle: i18n.t(i18n.l.transaction_details.actions_menu.cancel),
+                  menuAttributes: ['destructive' as const],


is this necessary to cast as const

yes, it considers 'destructive' as string but the type wants the it as the string literal type destructive, same stuff for the others as const or satisfies added, I expanded the type a lil bit, but in these cases opted to keep it like this so we have better auto complete

walmat · 2024-09-12T17:26:32Z

src/__swaps__/screens/Swap/components/GasButton.tsx

        <ContextMenuButton
-          activeOpacity={0}
          enableContextMenu
-          isAnchoredToRight
          isMenuPrimaryAction
          menuConfig={menuConfig}
          onPressMenuItem={handlePressMenuItem}
          useActionSheetFallback={false}
-          wrapNativeComponent={false}
        >


why were these props removed?

~~added isAnchoredToRight back didn't notice it's used in the .android~~, the others are already the default inside <ContextMenuButton />

btw seems like this GasButton menu is not working at all in android? idk if it's just my simulator

walmat · 2024-09-12T17:31:01Z

On Android the context menu is going offscreen a bit. I'd say this is low priority since I'm reworking context menus anyway, so dw about it, but just wanted to flag this.

…ng-nfts-on-android-is-broken

brunobar79 · 2024-09-17T04:00:51Z

Launch in simulator or device for f3f5f10

benisgold

idk if this is a bug or not, but i'd expect the "grayed out" option to be the one that's already selected which is currently not the case

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-17.at.11.34.10.mp4

* fix wc v2 change account issues * Update src/walletConnect/index.tsx * Update src/components/walletconnect-list/WalletConnectV2ListItem.tsx * Update src/components/walletconnect-list/WalletConnectV2ListItem.tsx * fix deps array

…#6162)

* init apechain support * fix wrong images * Apply suggestions from code review * Update chain badge * Update chain colors * Add all badge assets * add backend networks runtime * added back internal flag * remove unused NATIVE_ASSETS_PER_CHAIN * fix some discrepancies --------- Co-authored-by: Christian Baroni <[email protected]>

* analytics changes * idk * watched wallets cohort + properly track watched wallets

#6167) * wc ts conversion * remove memo and fix lint

* fix crash * destructure in same line

* prevent mwp flow from failing if failed to fetch dapp metadata * prevent logging user rejections * ignore logging some user errors

* fix networks crash * remove duplicated walletconnect chain ids * use all supported chains for walletconnect * fix weird space on approval sheet * Update src/screens/WalletConnectApprovalSheet.tsx

* hold -> tap * debounce

* chore: update swaps * chore: replace extraneous crosschain logic with needsAllowance field * chore: get rid of all WRAPPED_ASSET references and use quote swap type * chore: remove swapType as a param to get quotes * chore: replace swap unlock logic with needsAllowance field * chore: code review changes

* zeego setup * bump react-native-menu/menu * fix android settings menu * update deps * fix type inference * mvp to fix android context menus * fix some inconsistencies on Android * remove debug logs * Update src/components/asset-list/RecyclerAssetList2/core/RawRecyclerList.tsx * Update src/components/DropdownMenu.tsx * remove unused deps * fix build maybe * update lock

* fixes * fix experimental config usage * nits * use setTimeout * defaultConfig fix

…ng-nfts-on-android-is-broken

brunobar79 · 2024-10-16T05:43:14Z

Launch in simulator or device for f2bede0

brunobar79 · 2024-10-16T07:19:31Z

Launch in simulator or device for 42c906d

greg-schrammel added 8 commits August 26, 2024 15:26

sortDirection

3a18b2b

asc/desc menu

1df73e8

imports

d6ede1c

imports

1d355a9

i18n

d07935d

Merge remote-tracking branch origin/develop into gregs/app-1756-sorti…

473351b

…ng-nfts-on-android-is-broken

Merge remote-tracking branch origin/develop into gregs/app-1756-sorti…

cb4602b

…ng-nfts-on-android-is-broken

Merge remote-tracking branch origin/develop into gregs/app-1756-sorti…

fdc72e7

…ng-nfts-on-android-is-broken

greg-schrammel marked this pull request as draft August 30, 2024 20:19

fix types

01a0c9f

greg-schrammel marked this pull request as ready for review September 4, 2024 03:49

update ts

f8b2d4c

greg-schrammel requested review from walmat, benisgold and jinchung September 5, 2024 17:10

jinchung removed their request for review September 5, 2024 18:36

Merge branch 'develop' into gregs/app-1756-sorting-nfts-on-android-is…

b6a5c4a

…-broken

walmat reviewed Sep 12, 2024

View reviewed changes

src/components/cards/MintsCard/Menu.tsx Outdated Show resolved Hide resolved

walmat reviewed Sep 12, 2024

View reviewed changes

src/components/change-wallet/AddressRow.tsx Show resolved Hide resolved

walmat reviewed Sep 12, 2024

View reviewed changes

greg-schrammel added 3 commits September 16, 2024 23:49

add back isAnchoredToRight

a048dd9

??

8f84fd6

Merge remote-tracking branch origin/develop into gregs/app-1756-sorti…

32a1ee7

…ng-nfts-on-android-is-broken

benisgold reviewed Sep 17, 2024

View reviewed changes

brunobar79 and others added 24 commits October 16, 2024 01:37

comments watchdog action (#6153)

18314eb

pod unlock (#6168)

f688f32

Fix WalletconnectV2 changeAccount issues (#6160)

f0f3bf8

* fix wc v2 change account issues * Update src/walletConnect/index.tsx * Update src/components/walletconnect-list/WalletConnectV2ListItem.tsx * Update src/components/walletconnect-list/WalletConnectV2ListItem.tsx * fix deps array

bump android and iOS to version v1.9.42 (#6170)

a6f1357

fix approval sheet not using verifiedData incoming from walletconnect (…

2e900e7

…#6162)

Analytics changes (#6169)

9712448

* analytics changes * idk * watched wallets cohort + properly track watched wallets

[CHORE]: Walletconnect Approval / Redirect sheet typescript conversion (

92513f1

#6167) * wc ts conversion * remove memo and fix lint

nft expanded state fix crash (#6115)

6df14df

* fix crash * destructure in same line

fix lint issues on develop (#6174)

b272a12

Fix MWP from failing to prompt if dapp metadata retrieval fails (#6164)

f1a4544

* prevent mwp flow from failing if failed to fetch dapp metadata * prevent logging user rejections * ignore logging some user errors

lel wtf (#6166)

78d9d96

WC migration to WalletKit (#6163)

2fe9933

Fix networks crash (#6176)

f4ca59a

* fix networks crash * remove duplicated walletconnect chain ids * use all supported chains for walletconnect * fix weird space on approval sheet * Update src/screens/WalletConnectApprovalSheet.tsx

hide send button when not transferable (#6123)

caed4a7

Claim button fixes (#6165)

7ae60c8

* hold -> tap * debounce

fix lint (#6180)

67187c1

Claim bug fix (#6182)

250cc95

* fixes * fix experimental config usage * nits * use setTimeout * defaultConfig fix

fix ledger image blocking text

1eeb5a2

👍

4b493fe

Merge remote-tracking branch origin/develop into gregs/app-1756-sorti…

42b9a05

…ng-nfts-on-android-is-broken

lint

fb63c76

lint

12099e0

walmat approved these changes Oct 22, 2024

View reviewed changes

greg-schrammel merged commit 3897001 into develop Oct 22, 2024
8 checks passed

greg-schrammel deleted the gregs/app-1756-sorting-nfts-on-android-is-broken branch October 22, 2024 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nfts sort direction #6068

nfts sort direction #6068

greg-schrammel commented Aug 30, 2024 •

edited

Loading

linear bot commented Aug 30, 2024

socket-security bot commented Sep 4, 2024 •

edited

Loading

brunobar79 commented Sep 10, 2024

walmat Sep 12, 2024

greg-schrammel Sep 17, 2024

walmat Sep 12, 2024

greg-schrammel Sep 17, 2024 •

edited

Loading

greg-schrammel Sep 17, 2024

walmat commented Sep 12, 2024

brunobar79 commented Sep 17, 2024

benisgold left a comment

brunobar79 commented Oct 16, 2024

brunobar79 commented Oct 16, 2024

nfts sort direction #6068

nfts sort direction #6068

Conversation

greg-schrammel commented Aug 30, 2024 • edited Loading

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

linear bot commented Aug 30, 2024

socket-security bot commented Sep 4, 2024 • edited Loading

brunobar79 commented Sep 10, 2024

walmat Sep 12, 2024

Choose a reason for hiding this comment

greg-schrammel Sep 17, 2024

Choose a reason for hiding this comment

walmat Sep 12, 2024

Choose a reason for hiding this comment

greg-schrammel Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

greg-schrammel Sep 17, 2024

Choose a reason for hiding this comment

walmat commented Sep 12, 2024

brunobar79 commented Sep 17, 2024

benisgold left a comment

Choose a reason for hiding this comment

brunobar79 commented Oct 16, 2024

brunobar79 commented Oct 16, 2024

greg-schrammel commented Aug 30, 2024 •

edited

Loading

socket-security bot commented Sep 4, 2024 •

edited

Loading

greg-schrammel Sep 17, 2024 •

edited

Loading