Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test fix for unit tests #6080

Closed
wants to merge 2 commits into from
Closed

test fix for unit tests #6080

wants to merge 2 commits into from

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Sep 5, 2024 •
edited
Loading

This PR fixes the lint failure as seen in this action run: https://github.com/rainbow-me/rainbow/actions/runs/10708629212/job/29694446365

this will still fail e2e fwiw but should pass yarn test

brunobar79
brunobar79 reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the description of the PR? Basically what specific error are you fixing

@walmat walmat requested a review from brunobar79 September 6, 2024 14:36
@walmat walmat closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benisgold benisgold Awaiting requested review from benisgold

@BrodyHughes BrodyHughes Awaiting requested review from BrodyHughes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walmat @brunobar79