-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework remote promo sheet logic / designs #6085
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
05c072f
immediately set isShown when we're going to show a sheet
walmat d4fffff
improvements to remote promo sheets
walmat 421d308
partialize persistence and fix some light mode / dark mode oddities
walmat 0c25116
Merge branch 'develop' into @matthew/improve-remote-promo-sheets
ibrahimtaveras00 527e6f4
add targeted version check
walmat 37a0b79
rename func
walmat f79058b
fix type
walmat 96f3a78
fix exported function name
walmat 397aa9b
fix promo sheet check to handle all multiple addresses
walmat 8331fb8
improve checks
walmat 7a1a2ea
re-memo sync
walmat 4692d1a
cleanup
walmat 81276b5
undo address specific store change
walmat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
src/components/remote-promo-sheet/check-fns/__tests__/isTargetedVersionOrNewer.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { isTargetedVersionOrNewer } from '../isTargetedVersionOrNewer'; | ||
| import * as DeviceInfo from 'react-native-device-info'; | ||
|
|
||
| jest.mock('react-native-device-info', () => ({ | ||
| getVersion: jest.fn(), | ||
| })); | ||
|
|
||
| describe('isTargetedVersionOrNewer', () => { | ||
| afterEach(() => { | ||
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it('should return true when current app version is newer than version to check', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('2.0.0'); | ||
| const result = await isTargetedVersionOrNewer('1.9.0'); | ||
| expect(result).toBe(true); | ||
| }); | ||
|
|
||
| it('should return false when current app version is older than version to check', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('1.8.0'); | ||
| const result = await isTargetedVersionOrNewer('1.9.0'); | ||
| expect(result).toBe(false); | ||
| }); | ||
|
|
||
| it('should return true when versions are equal', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('1.9.0'); | ||
| const result = await isTargetedVersionOrNewer('1.9.0'); | ||
| expect(result).toBe(true); | ||
| }); | ||
|
|
||
| it('should handle patch versions correctly', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('1.9.1'); | ||
| const result = await isTargetedVersionOrNewer('1.9.0'); | ||
| expect(result).toBe(true); | ||
| }); | ||
|
|
||
| it('should handle versions with different number of parts', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('2.0'); | ||
| const result = await isTargetedVersionOrNewer('1.9.9'); | ||
| expect(result).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true when versions are equal but have different number of parts', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('2.0.0'); | ||
| const result = await isTargetedVersionOrNewer('2.0'); | ||
| expect(result).toBe(true); | ||
| }); | ||
|
|
||
| it('should return false when current app version is older with different number of parts', async () => { | ||
| (DeviceInfo.getVersion as jest.Mock).mockReturnValue('1.9'); | ||
| const result = await isTargetedVersionOrNewer('2.0.0'); | ||
| expect(result).toBe(false); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only shouldn't show if we don't have the data, regardless of error