Swaps deeplink #6178

greg-schrammel · 2024-10-08T11:57:27Z

Fixes APP-1234

What changed (plus any additional context for devs)

inputAsset: UniqueId
outputAsset: UniqueId

inputAmount: Number
outputAmount: Number
percentageToSell: Number // value between 0 and 1

gasSpeed: 'normal' | 'fast' | 'urgent'
slippage: Number
flashbots: Boolean

from: Address

with assets

inputAsset and outputAsset expects a UniqueId (address_chainId)
ex: rainbow://swaps?inputAsset=0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48_1

with prefilled values

percentageToSell > inputAmount > outputAmount only one is used, in this order of importance
percentageToSell expects a value between 0 and 1
ex: rainbow://swaps?inputAsset=eth_1&percentageToSell=0.2, 20% of wallet swappable ETH

with gasSpeed

values are normal,fast or urgent
ex: rainbow://swaps?gasSpeed=urgent

with flashbots

param not included does not mean false, keeps user preferences
flashbots=true any other value besides true means false
ex: rainbow://swaps?flashbots=true

with slipagge

in bips slippage=100 = 1% slippage
ex: rainbow://swaps?slippage=100

with from

let you navigate to another wallet, param is silently ignored if you don't own the wallet
ex: rainbow://swaps?from=0x507F0daA42b215273B8a063B092ff3b6d27767aF

Screen recordings / screenshots

What to test

multiple weird combinations of params
with app open and app closed

to test in ios you can run xcrun simctl openurl booted 'rainbow://swap/?outputAsset=0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48_1&gasSpeed=urgent&flashbots=true&inputAmount=1&inputAsset=eth_1'

branch is blocking some vpns, when trying to open deeplinks while connected to a vpn it would fail to connect to branch servers and return an empty params object, not undefined, empty `params: {}`, in turn making the app ignore the deeplink and not open it

linear · 2024-10-08T11:57:46Z

APP-1234 Deeplinks to swaps

brunobar79 · 2024-10-08T12:49:39Z

Launch in simulator or device for afa7d2e

walmat

Mostly comments that I need clarity on, a few actual changes that I think could make the flow even better:

parallelize some of the network requests
safeguards against division by 0, undefined cases, etc.
make sure the default 50% slider position if no inputAmount is defined hasn't regressed.

Otherwise, great work!

ios/Rainbow.xcodeproj/project.pbxproj

src/handlers/deeplinks.ts

src/state/swaps/swapsStore.ts

walmat · 2024-10-24T14:47:34Z

src/__swaps__/screens/Swap/hooks/useSwapInputsController.ts

+  if (internalSelectedInputAsset.value && internalSelectedOutputAsset.value) {
+    fetchQuoteAndAssetPrices();
+  }
+


i don't think this is necessary since it should be handled via a useAnimatedReaction.

walmat · 2024-10-24T14:47:52Z

src/__swaps__/screens/Swap/hooks/useSwapInputsController.ts

@@ -657,6 +691,7 @@ export function useSwapInputsController({
      assetToSellNetwork: internalSelectedInputAsset.value?.chainId,
    }),
    (current, previous) => {
+      if (!previous) return;


why was this added?

still curious about this

src/__swaps__/screens/Swap/providers/swap-provider.tsx

brunobar79 · 2024-10-28T21:36:06Z

Launch in simulator or device for d51e895

brunobar79 · 2024-10-29T09:13:58Z

Launch in simulator or device for 7e95ffb

derHowie · 2024-11-25T17:37:37Z

hey @greg-schrammel, did we end up getting blocked / deprioritizing this?

greg-schrammel · 2024-11-25T18:52:14Z

hey @greg-schrammel, did we end up getting blocked / deprioritizing this?

no I moved to other stuff and forgot about it, just fixed the conflicts

brunobar79 · 2024-11-25T21:08:39Z

Launch in simulator or device for 4c3d7cf

brunobar79 · 2024-11-26T22:29:49Z

Launch in simulator or device for dc3803c

derHowie · 2024-12-03T14:41:26Z

src/__swaps__/screens/Swap/hooks/useSwapInputsController.ts

@@ -657,6 +691,7 @@ export function useSwapInputsController({
      assetToSellNetwork: internalSelectedInputAsset.value?.chainId,
    }),
    (current, previous) => {
+      if (!previous) return;


derHowie · 2024-12-03T14:46:51Z

src/__swaps__/screens/Swap/navigateToSwaps.ts

+export function getSwapsNavigationParams() {
+  const params = (Navigation.getActiveRoute().params || {}) as SwapsParams;
+
+  const inputMethod = getInputMethod(params);
+  const lastTypedInput = inputMethod === 'slider' ? 'inputAmount' : inputMethod;
+
+  const state = useSwapsStore.getState();
+  return {
+    inputMethod,
+    lastTypedInput,
+    focusedInput: lastTypedInput,
+    inputAsset: params.inputAsset || state.inputAsset,
+    outputAsset: params.outputAsset || state.outputAsset,
+    ...params,
+  } as const;
+}


consumers of this function will think getSwapsNavigationParams().inputAsset and getSwapsNavigationParams().outputAsset are guaranteed.

can you tweak this fn to reflect that they're optional?

they are typed as ParsedSearchAsset | null

src/__swaps__/screens/Swap/resources/assets/userAssets.ts

src/handlers/deeplinks.ts

brunobar79 · 2024-12-04T19:24:36Z

Launch in simulator or device for 60f5eff

* Browser upgrades (#6269) * Dapp browser upgrades * Remove unneeded whitelisted native text prop * Clean up SwipeNavigator tab bar components * Remove BPA wrapper from GestureHandlerButton Also adds turbo-haptics and an internal scale animation, giving GestureHandlerButton full platform parity * freezeStore → navigationStore * Restructure browser gesture handlers, code cleanup * Make useKeyboardHeight more efficient * TextShadow: Add support for AnimatedText * Remove commented code * Fix lint error * Remove commented code * Force a new WebView when the content process dies Reloading the page by calling reload() on the ref doesn't successfully restart the WebView. This was causing tabs to occasionally become blank after the app sat backgrounded for long enough, and upon returning to the app they'd be stuck. This change forces a new WebView by providing a new key, which should resolve the issue. * Minor gesture cleanup * Add common gesture options to GestureHandlerButton * Bump packages * Fix manual activation bug in RNGH Fixes a bug that exists with manually activated gestures where when the app returns to the foreground, the first interaction with the manually activated handler doesn't trigger any events * Fix type issue in react-native-view-shot RN was complaining that this iOS code was not Android compliant * Only render WebViewBorder on iOS, misc. cleanup * Adjust ScrollView/tabs hierarchy, props cleanup * Bump Skia * Remove activeTabInfo.value.tabId No longer needed as there's a dedicated activeTabId Shared Value * Make tab switching lighter, add getTabInfo helper A few tab switching styles were applied for all tabs when tab switching, when only the active tab and the tabs to the left and right need full-size tab styles * Smooth out height animations * Clean up scripts, clamp tab height * Clean up WebView handlers * Improve tab animation performance - Removed unnecessary isSwitchingTabs (`tabViewGestureState` serves the same purpose) - Removed a wrapper view around each tab and merged most animated tab styles into `animatedWebViewStyle` - In `animatedWebViewStyle`, now passing values to the style generation worklets instead of passing the Shared Values themselves * Make screenshot flicker less likely, improve tab switching reset - Now setting the JS-side active tab index first so it gets a tiny head start (the JS and SV active indexes inform which tab activates and when tab screenshots are shown/hidden) - Now resetting tab switching state *before* updating `activeTabId` and `animatedActiveTabIndex` (instead of after) — this fixes an edge case where the switch animation would occasionally be skipped, if you switched tabs again at the exact moment a previous tab switch ended * Make isNewIndexValid a boolean * Fix bad worklet pattern Because getTabInfo is stable and the SVs used within getTabInfo weren't visible to the useAnimatedStyle hooks, styles weren't recomputing for changes in getTabInfo's input values — same idea applies to useDerivedValue, useAnimatedReaction prepare functions, etc. * revert third party positions enabled (#6298) * chain badges * Swaps deeplink (#6178) * fix branch branch is blocking some vpns, when trying to open deeplinks while connected to a vpn it would fail to connect to branch servers and return an empty params object, not undefined, empty `params: {}`, in turn making the app ignore the deeplink and not open it * aaa * aaaaaa * remove unused imports * fix type * ops * better validations * opsi inverted the conditions * revert pbxproj changes * setFromWallet * fix typo & code style * remove uncessary stuff --------- Co-authored-by: Matthew Wall <[email protected]> * add eth rewards to claimables and make it discoverable by watchers --------- Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Kane Thomas <[email protected]> Co-authored-by: gregs <[email protected]> Co-authored-by: Matthew Wall <[email protected]>

* progress * progress * progress * testing * progress * progress * crosschain quote working * claim + crosschainswap rap worked * raps logic is done * delete v2 * cleanup * working on dropdowns * little dropdown refactor * useDropdownMenu hook * refactoring * working on dropdown * basically done with ui refactor * fixes * claim as x is working * context work * progress * gas * enormous refactor, need to fix some things * gas fixes * pretty sure i fixed quotes * functional * wrapping things up * cleaning up * fixes * more fixes * fix formatting * lint * gas and quote state fixes * rm logs * error messages * error messages + i18n * fix bug that allowed button press w/o token/chain selected * disable watched wallets * error logging in executeClaim * i18n * slippage * add comments to transaction context * comments * rainbow fee * adjust rainbow fee * gas improvements * forgot to undo this * fix gas race condition * fix swap data assetToSell bug * rm comment * improve error logging in raps * nit * temp, merging develop * fix gas estimation * rm unused imports * rm console log * rm dai, wbtc, add usdc * fix quote amount + fix gas estimation throttling * rename txState to gasState * more gas fixes * network icons for dropdown menu * fix populateSwap util and some other minor things * fix analyticsId * fix scenario where user does not have native asset for gas calculations * fix context menu ordering on android * fix gas estimation * undo obsolete change * fix analytics * Claimables followups (#6301) * Browser upgrades (#6269) * Dapp browser upgrades * Remove unneeded whitelisted native text prop * Clean up SwipeNavigator tab bar components * Remove BPA wrapper from GestureHandlerButton Also adds turbo-haptics and an internal scale animation, giving GestureHandlerButton full platform parity * freezeStore → navigationStore * Restructure browser gesture handlers, code cleanup * Make useKeyboardHeight more efficient * TextShadow: Add support for AnimatedText * Remove commented code * Fix lint error * Remove commented code * Force a new WebView when the content process dies Reloading the page by calling reload() on the ref doesn't successfully restart the WebView. This was causing tabs to occasionally become blank after the app sat backgrounded for long enough, and upon returning to the app they'd be stuck. This change forces a new WebView by providing a new key, which should resolve the issue. * Minor gesture cleanup * Add common gesture options to GestureHandlerButton * Bump packages * Fix manual activation bug in RNGH Fixes a bug that exists with manually activated gestures where when the app returns to the foreground, the first interaction with the manually activated handler doesn't trigger any events * Fix type issue in react-native-view-shot RN was complaining that this iOS code was not Android compliant * Only render WebViewBorder on iOS, misc. cleanup * Adjust ScrollView/tabs hierarchy, props cleanup * Bump Skia * Remove activeTabInfo.value.tabId No longer needed as there's a dedicated activeTabId Shared Value * Make tab switching lighter, add getTabInfo helper A few tab switching styles were applied for all tabs when tab switching, when only the active tab and the tabs to the left and right need full-size tab styles * Smooth out height animations * Clean up scripts, clamp tab height * Clean up WebView handlers * Improve tab animation performance - Removed unnecessary isSwitchingTabs (`tabViewGestureState` serves the same purpose) - Removed a wrapper view around each tab and merged most animated tab styles into `animatedWebViewStyle` - In `animatedWebViewStyle`, now passing values to the style generation worklets instead of passing the Shared Values themselves * Make screenshot flicker less likely, improve tab switching reset - Now setting the JS-side active tab index first so it gets a tiny head start (the JS and SV active indexes inform which tab activates and when tab screenshots are shown/hidden) - Now resetting tab switching state *before* updating `activeTabId` and `animatedActiveTabIndex` (instead of after) — this fixes an edge case where the switch animation would occasionally be skipped, if you switched tabs again at the exact moment a previous tab switch ended * Make isNewIndexValid a boolean * Fix bad worklet pattern Because getTabInfo is stable and the SVs used within getTabInfo weren't visible to the useAnimatedStyle hooks, styles weren't recomputing for changes in getTabInfo's input values — same idea applies to useDerivedValue, useAnimatedReaction prepare functions, etc. * revert third party positions enabled (#6298) * chain badges * Swaps deeplink (#6178) * fix branch branch is blocking some vpns, when trying to open deeplinks while connected to a vpn it would fail to connect to branch servers and return an empty params object, not undefined, empty `params: {}`, in turn making the app ignore the deeplink and not open it * aaa * aaaaaa * remove unused imports * fix type * ops * better validations * opsi inverted the conditions * revert pbxproj changes * setFromWallet * fix typo & code style * remove uncessary stuff --------- Co-authored-by: Matthew Wall <[email protected]> * add eth rewards to claimables and make it discoverable by watchers --------- Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Kane Thomas <[email protected]> Co-authored-by: gregs <[email protected]> Co-authored-by: Matthew Wall <[email protected]> * fix hook usage * lint * wallet screen fix * dont throw errors in rap creation * remove claimable asset from dropdown if network is not compatible * rm unnecessary useCallback dep * show wallet error alert if can't load wallet * fix approval target --------- Co-authored-by: Christian Baroni <[email protected]> Co-authored-by: Kane Thomas <[email protected]> Co-authored-by: gregs <[email protected]> Co-authored-by: Matthew Wall <[email protected]>

greg-schrammel added 3 commits October 2, 2024 13:32

fix branch

5e8ce05

branch is blocking some vpns, when trying to open deeplinks while connected to a vpn it would fail to connect to branch servers and return an empty params object, not undefined, empty `params: {}`, in turn making the app ignore the deeplink and not open it

aaa

4c05bc0

aaaaaa

f0a5d5f

walmat reviewed Oct 24, 2024

View reviewed changes

Merge branch 'develop' into swaps-deeplink

46efe19

greg-schrammel added 6 commits October 29, 2024 05:26

remove unused imports

65cc587

fix type

2331644

ops

1da6b39

better validations

578439d

opsi inverted the conditions

d4ec8c2

revert pbxproj changes

247d71c

greg-schrammel requested review from walmat and benisgold October 29, 2024 20:58

brunobar79 added the nice for release label Oct 31, 2024

Merge branch 'develop' into swaps-deeplink

9f83d34

setFromWallet

df8b840

Merge branch 'develop' into swaps-deeplink

5ab624d

walmat approved these changes Nov 26, 2024

View reviewed changes

brunobar79 added release for release blockers and release candidate branches and removed nice for release labels Dec 2, 2024

brunobar79 requested review from derHowie and removed request for benisgold December 2, 2024 18:29

derHowie reviewed Dec 3, 2024

View reviewed changes

fix typo & code style

28e442d

derHowie approved these changes Dec 4, 2024

View reviewed changes

remove uncessary stuff

f746d0c

greg-schrammel merged commit 03bfb03 into develop Dec 4, 2024
8 checks passed

greg-schrammel deleted the swaps-deeplink branch December 4, 2024 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swaps deeplink #6178

Swaps deeplink #6178

greg-schrammel commented Oct 8, 2024 •

edited

Loading

linear bot commented Oct 8, 2024

brunobar79 commented Oct 8, 2024

walmat left a comment

walmat Oct 24, 2024

walmat Oct 24, 2024

walmat Nov 6, 2024

derHowie Dec 3, 2024

brunobar79 commented Oct 28, 2024

brunobar79 commented Oct 29, 2024

derHowie commented Nov 25, 2024

greg-schrammel commented Nov 25, 2024 •

edited

Loading

brunobar79 commented Nov 25, 2024

brunobar79 commented Nov 26, 2024

derHowie Dec 3, 2024

derHowie Dec 3, 2024

greg-schrammel Dec 4, 2024

brunobar79 commented Dec 4, 2024

Swaps deeplink #6178

Swaps deeplink #6178

Conversation

greg-schrammel commented Oct 8, 2024 • edited Loading

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

linear bot commented Oct 8, 2024

brunobar79 commented Oct 8, 2024

walmat left a comment

Choose a reason for hiding this comment

walmat Oct 24, 2024

Choose a reason for hiding this comment

walmat Oct 24, 2024

Choose a reason for hiding this comment

walmat Nov 6, 2024

Choose a reason for hiding this comment

derHowie Dec 3, 2024

Choose a reason for hiding this comment

brunobar79 commented Oct 28, 2024

brunobar79 commented Oct 29, 2024

derHowie commented Nov 25, 2024

greg-schrammel commented Nov 25, 2024 • edited Loading

brunobar79 commented Nov 25, 2024

brunobar79 commented Nov 26, 2024

derHowie Dec 3, 2024

Choose a reason for hiding this comment

derHowie Dec 3, 2024

Choose a reason for hiding this comment

greg-schrammel Dec 4, 2024

Choose a reason for hiding this comment

brunobar79 commented Dec 4, 2024

greg-schrammel commented Oct 8, 2024 •

edited

Loading

greg-schrammel commented Nov 25, 2024 •

edited

Loading