fix: present hw pairing sheet during swap #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
force-pushed
the
@chris/swap-ledger-sheet
branch
from
4239d6d to
71db231
Compare
walmat
reviewed
Nov 27, 2024
Comment on lines
343
to
347
| if ( | ||
| index === 0 || | ||
| routes[index - 1] === Routes.EXPANDED_ASSET_SHEET || | ||
| activeRoute.name === Routes.PAIR_HARDWARE_WALLET_AGAIN_SHEET | ||
| ) { |
There was a problem hiding this comment.
I know this wasn't introduced in your PR, but can we specify what these checks are? I'm a little confused what index === 0 implies. Something like:
const isOnlyRoute = index === 0; // not sure if this is actually what this means?
const isFromExpandedSheet = ...
const isFromHardwareWalletSheet = ...
There was a problem hiding this comment.
I have a feeling that both of those cases do not fit the typical shape of routes. I hadn't yet had time to check out that expanded sheet flow yet.
I'll try to verify that either of these are necessary. Then make them more legible.
Co-authored-by: gregs <[email protected]>
greg-schrammel
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1928
What changed (plus any additional context for devs)
We have added the ledger bluetooth sheet back to the swap flow. Ledger transactions were working, however we were not displaying the various bluetooth connection states.
Screen recordings / screenshots
RPReplay_Final1732665403.MP4
What to test
Attempt a swap with a ledger device. Make sure you see the bluetooth connection sheet.