Implement Active Tab flag for dapp browser #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbbb
approved these changes
Nov 27, 2024
derHowie
approved these changes
Nov 27, 2024
|
@brunobar79 lgtm but looks like we'll need to tweak the type in js land: |
The changes are already done in the patch. That will pass once the other PR it's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-
What changed (plus any additional context for devs)
Exposed a new method
setActiveon the webviewRequires https://github.com/rainbow-me/rainbow-scripts/pull/186
Screen recordings / screenshots
Available on rainbow-scripts related PR
What to test
Instructions available on rainbow-scripts related PR
(e2e is expected to fail until the other PR gets merged in)