Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use timeframe volume instead of volume_24h in trending #6371

Closed
wants to merge 1 commit into from

Conversation

DanielSinclair
Copy link
Contributor

Fixes APP-####

What changed (plus any additional context for devs)

  • adopting timeframe-based volume, instead of 24h market volume in Trending
  • this is currently a workaround; we should add a proper query param in the market query

Screen recordings / screenshots

What to test

@DanielSinclair DanielSinclair changed the title fix: use timeframe volume instead of market.volume_24h fix: use timeframe volume instead of volume_24h in trending Dec 23, 2024
@DanielSinclair DanielSinclair marked this pull request as draft December 23, 2024 09:30
@brunobar79
Copy link
Member

Launch in simulator or device for 2f4d0bd

Base automatically changed from @christian/trending-tokens-fixes to develop December 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants