Clean up change_queue_size_of matcher, fix Time#to_s deprecation
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'actual' makes sense for a standard matcher but less so for a block matcher - new isn't a great variable name Also, remove the unneeded '|| 1' clause, since that's already in #amount.
This fixes a Rails 7 deprecation warning. See rails/rails#43772
magni-
force-pushed
the
pp/fix-have_changed_queue_size-copy
branch
from
67f5774 to
cbf722c
Compare
|
/reviewme @rainforestapp/devs |
pyromaniackeca
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part is commits I had locally from months ago, I don't remember why I made them in the first place, but they seem to be useful?
The last commit is to fix failures that popped up in Rails 7.0.7 dependabot PRs, due to this deprecation: rails/rails#43772
queue_classic_matchersrequiresactive_record, which requiresactive_support, so we always have access toTime#to_fs.