Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Implement a list method #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions cmd/drive/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var context *config.Context

const (
descInit = "inits a directory and authenticates user"
descList = "list files on google drive"
descPull = "pulls remote changes from google drive"
descPush = "push local changes to google drive"
descDiff = "compares a local file with remote"
Expand All @@ -38,6 +39,7 @@ const (

func main() {
command.On("init", descInit, &initCmd{}, []string{})
command.On("list", descList, &listCmd{}, []string{})
command.On("pull", descPull, &pullCmd{}, []string{})
command.On("push", descPush, &pushCmd{}, []string{})
command.On("diff", descDiff, &diffCmd{}, []string{})
Expand All @@ -55,6 +57,21 @@ func (cmd *initCmd) Run(args []string) {
exitWithError(drive.New(initContext(args), nil).Init())
}

type listCmd struct {
}

func (cmd *listCmd) Flags(fs *flag.FlagSet) *flag.FlagSet {
return fs
}

func (cmd *listCmd) Run(args []string) {
context, path := discoverContext(args)
exitWithError(drive.New(context, &drive.Options{
Path: path,
}).List())
}


type pullCmd struct {
isRecursive *bool
isNoPrompt *bool
Expand Down
43 changes: 43 additions & 0 deletions list.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// Copyright 2013 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package drive

import (
"fmt"
)

// List remote files if remote path exists. If path is a
// directory, it recursively lists
func (g *Commands) List() (err error) {
var r *File
if r, err = g.rem.FindByPath(g.opts.Path); err != nil {
return
}

if (!r.IsDir) {
fmt.Println(r.Name)
return
}

var remoteChildren []*File
if remoteChildren, err = g.rem.FindByParentId(r.Id); err != nil {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do pagination on FindByParentId. It returns only the top 100 children.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look! I implemented that in #24. Are you saying there is some additional work?

return
}

for _, rc := range remoteChildren {
fmt.Println(rc.Name)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to alter what we print out depending on the file MIME type, need to distinguish directories from regular files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Makes sense I'll give that a shot.

}
return
}