Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove database backend #489 #507

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joshuadkitenge
Copy link

@joshuadkitenge joshuadkitenge commented Nov 26, 2024

This PR will close #489

Description

Remove the database backend functionality from the DataGateway API. It includes significant changes such as deleting database-related files and functionality, updating tests to remove database dependencies, and modifying the configuration to align with the changes.

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Connect to #489

@joshuadkitenge joshuadkitenge changed the title refactor: remove database backend #469 remove database backend #469 Nov 26, 2024
@joshuadkitenge joshuadkitenge changed the title remove database backend #469 remove database backend #489 Nov 26, 2024
@joshuadkitenge joshuadkitenge force-pushed the remove-database-backend-#489 branch from 5e5d6c4 to 743b34b Compare November 26, 2024 16:57
@joshuadkitenge joshuadkitenge force-pushed the remove-database-backend-#489 branch 4 times, most recently from 86a347f to c3a28c4 Compare December 2, 2024 13:56
@joshuadkitenge joshuadkitenge force-pushed the remove-database-backend-#489 branch from c3a28c4 to 2939010 Compare December 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Database Backend
1 participant