Edit exception message when editing certain fields of a catalogue item with children

[rowan04]

Description

Edit the returned exception message to make it clearer when trying to update protected fields on a catalogue item or catalogue category that has a child element.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage
• {more steps here}

Agile board tracking

Resolves #353

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (e5f2e8c) to head (3cdae51).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #418   +/-   ##
========================================
  Coverage    97.87%   97.87%           
========================================
  Files           41       41           
  Lines         1504     1504           
========================================
  Hits          1472     1472           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[joelvdavies]

General comment could you perhaps list the fields from CATALOGUE_ITEM_WITH_CHILD_NON_EDITABLE_FIELDS so it's kept up to date with changes. Also I just noticed we also have exactly the same sort of error message for the catalogue category edit could you update these as well so they are consistent.

The front end may need a change to be more user friendly

[rowan04]

The linter check is failing, but I'm pretty sure all the lines I added are under 120. So is this failing because of previously written lines in the files I edited?

[joelvdavies]

The linter check is failing, but I'm pretty sure all the lines I added are under 120. So is this failing because of previously written lines in the files I edited?

Could be that your local version of black needs updating or vscode isn't autoformatting correctly. You can use python3.12 -m black --line-length 120 . to run it locally. To update your version of black in the venv use python3.12 -m pip install -e .[dev] again. If you haven't already setup formatting on vscode I can give you the settings I use.

[rowan04]

The linter check is failing, but I'm pretty sure all the lines I added are under 120. So is this failing because of previously written lines in the files I edited?

Could be that your local version of black needs updating or vscode isn't autoformatting correctly. You can use python3.12 -m black --line-length 120 . to run it locally. To update your version of black in the venv use python3.12 -m pip install -e .[dev] again. If you haven't already setup formatting on vscode I can give you the settings I use.

[joelvdavies]

LGTM. I added a corresponding front end issue here ral-facilities/inventory-management-system#1136.