Gallery View and image info dialog #1081 #1099 #1083 #1082 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove cardView footer
- Add MRT action menu and checkbox to card view and gallery lightbox
…age-information-dialog-#1082-#1083
- remove max height in thumbnail - one image should have a max length of 50%
joshuadkitenge
force-pushed
the
custom-light-box
branch
from
0e80928 to
6489da8
Compare
joshuadkitenge
changed the title
joshuadkitenge
force-pushed
the
custom-light-box
branch
from
6489da8 to
c16564c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1145 +/- ##
===========================================
+ Coverage 99.19% 99.23% +0.04%
===========================================
Files 82 88 +6
Lines 17094 17876 +782
Branches 2051 2946 +895
===========================================
+ Hits 16956 17740 +784
+ Misses 137 135 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
changed the base branch from
feature/image-information-dialog-#1082-#1083
to
develop
joshuadkitenge
changed the base branch from
develop
to
feature/image-information-dialog-#1082-#1083
joshuadkitenge
changed the base branch from
feature/image-information-dialog-#1082-#1083
to
develop
joshuadkitenge
changed the title
This was referenced Dec 4, 2024
Closed
joelvdavies
reviewed
Dec 5, 2024
joshuadkitenge
force-pushed
the
custom-light-box
branch
2 times, most recently
from
a9c606e to
5653237
Compare
joshuadkitenge
force-pushed
the
custom-light-box
branch
from
5653237 to
9dadad5
Compare
joelvdavies
reviewed
Dec 9, 2024
Comment on lines
+344
to
+347
| (images.length % preservedState.pagination.pageSize === | ||
| 1 && | ||
| isLastPage) | ||
| ? '50%' |
There was a problem hiding this comment.
This still happens when filtering so there is only one result
joelvdavies
reviewed
Dec 9, 2024
- Filtering size issue
asuresh-code
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove react-photoswipe-gallery and use custom lightbox
Testing instructions
closes #1081, closes #1099, closes #1083, closes #1082