Add Delete Image #1150
Add Delete Image #1150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1150 +/- ##
=========================================
Coverage 99.23% 99.24%
=========================================
Files 88 89 +1
Lines 17876 17982 +106
Branches 2123 2966 +843
=========================================
+ Hits 17740 17846 +106
+ Misses 135 132 -3
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
server/e2e-settings-with-api.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "imsApiUrl": "http://127.0.0.1:8000", | |||
| "osApiUrl": "", | |||
There was a problem hiding this comment.
This doesn't need to be change. This should be changed when the object-storage-api is added into the CI
| const [error, setError] = React.useState(false); | ||
| const [errorMessage, setErrorMessage] = React.useState<string | undefined>( |
There was a problem hiding this comment.
You on need to use the errorMessage to manage the state as the its false when it undefined , otherwise its true
I'm not sure if the error I recreated and addressed was exactly what you found; I believe the issue is that after you delete an image in the lightbox, it tries to GET the image, only to get this error since it does not exist anymore. I've fixed it by simply closing the lightbox if you delete an image. |
Description
#1074
Testing instructions
Checkout
**add-delete-endpoint-for-image-#38**on the Object Storage API repo to test with the api.Agile board tracking
closes #1074