Uppy refresh token logic #1152
Draft
Uppy refresh token logic #1152
+78
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix existing code so it use relevant api client instead of imsApi - refactor thumbnail view logic to use displayed images - remove upload error uppy event listener as it not needed as backend deals with image errors - create uppy uppyOnBeforeRequest function that set the auth headers - create uppyOnAfterResponse to deal with 403 errors
joshuadkitenge
commented
Dec 11, 2024
Comment on lines
+132
to
+137
| const timeoutId = setTimeout(() => { | ||
| // If the token isn't refreshed within a reasonable timeframe, reject the promise | ||
| document.removeEventListener(MicroFrontendId, handler); | ||
| isFetchingAccessToken = false; | ||
| reject(); | ||
| }, 20 * 1000); // 20 seconds timeout |
There was a problem hiding this comment.
Added a reject case to handle scenarios where the expected CustomEvent does not occur or takes too long.
Ensures the Promise does not hang indefinitely
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1152 +/- ##
===========================================
- Coverage 99.23% 99.03% -0.21%
===========================================
Files 88 88
Lines 17876 17920 +44
Branches 2946 2947 +1
===========================================
+ Hits 17740 17747 +7
- Misses 135 169 +34
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Agile board tracking
closes #1147