Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance catalogue category card filters #1124 #1156

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

joshuadkitenge
Copy link
Collaborator

Description

see #1124

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1124

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 85.05747% with 13 lines in your changes missing coverage. Please review.

Project coverage is 99.16%. Comparing base (718d659) to head (d24be52).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/utils.tsx 35.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1156      +/-   ##
===========================================
- Coverage    99.23%   99.16%   -0.08%     
===========================================
  Files           88       88              
  Lines        17876    17932      +56     
  Branches      2123     2946     +823     
===========================================
+ Hits         17740    17782      +42     
- Misses         135      146      +11     
- Partials         1        4       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge marked this pull request as ready for review December 16, 2024 11:21
Copy link
Contributor

@asuresh-code asuresh-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just have a few minor comments.

src/utils.tsx Outdated Show resolved Hide resolved
@asuresh-code
Copy link
Contributor

I tested arrExcludesSome, and it doesn't seem to work properly on the catalogue category filters.
image
It should filter out Motorized Actuators which has all of these properties but does not.

When I implemented it, it wasn't meant to handle row values that are lists, so I think an implementation similar to what you have done for the 2 new functions should address it.

@joshuadkitenge
Copy link
Collaborator Author

joshuadkitenge commented Dec 16, 2024

I tested arrExcludesSome, and it doesn't seem to work properly on the catalogue category filters. image It should filter out Motorized Actuators which has all of these properties but does not.

When I implemented it, it wasn't meant to handle row values that are lists, so I think an implementation similar to what you have done for the 2 new functions should address it.

I've refactored the code so now it just uses the MRT Table function. The types have been matched to same as MRT / tanstack table

@joshuadkitenge joshuadkitenge merged commit 148db7b into develop Dec 17, 2024
6 checks passed
@joshuadkitenge joshuadkitenge deleted the enhance-catalogue-category-card-filters-#1124 branch December 17, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance catalogue categories card view filtering
2 participants