Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check username when refreshing access token #87

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Check username when refreshing access token #87

merged 3 commits into from
Jun 12, 2024

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Jun 11, 2024 •
edited by joelvdavies
Loading

Description

Adds the username to the refresh tokens and checks that the usernames in the access and refresh tokens match before refreshing the access token.

Testing instructions

  • Review code
  • Check Actions build
  • Test refreshing an access token with usernames that are matching and not matching

Agile board tracking

closes #86

@VKTB VKTB marked this pull request as ready for review June 11, 2024 15:19
@VKTB VKTB requested a review from joelvdavies June 11, 2024 15:19
joelvdavies
joelvdavies approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@VKTB VKTB merged commit 0a4a699 into main Jun 12, 2024
5 checks passed
@VKTB VKTB deleted the check-usernames-in-tokens-#86 branch June 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelvdavies joelvdavies joelvdavies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check username when refreshing access token
2 participants
@VKTB @joelvdavies