Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement verify endpoint #9

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Implement verify endpoint #9

merged 13 commits into from
Jan 23, 2024

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Dec 21, 2023

Description

Implements a /verify POST endpoint and relevant application logic that takes a JWT token and verifies that the authentication service generated it.

Testing instructions

Add a set of instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Supply valid JWT token
  • Supply invalid JWT token

Agile board tracking

closes #8

@VKTB VKTB changed the base branch from main to implement-login-endpoint-#6 December 21, 2023 16:29
@VKTB VKTB requested a review from joelvdavies January 12, 2024 09:27
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single suggestion, although same query about tests/pylint failing (but probably addressed in #7 anyway).

ldap_jwt_auth/routers/verify.py Outdated Show resolved Hide resolved
@VKTB VKTB requested a review from joelvdavies January 17, 2024 17:46
Base automatically changed from implement-login-endpoint-#6 to main January 18, 2024 13:01
ldap_jwt_auth/routers/verify.py Outdated Show resolved Hide resolved
ldap_jwt_auth/routers/verify.py Outdated Show resolved Hide resolved
@VKTB VKTB requested a review from joelvdavies January 19, 2024 15:05
@VKTB VKTB merged commit 04910b8 into main Jan 23, 2024
2 checks passed
@VKTB VKTB deleted the implement-verify-endpoint-#8 branch January 23, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement verify endpoint
2 participants