Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance and scheduled endpoints #88 #96

Merged
merged 32 commits into from
Jul 3, 2024
Merged

Add maintenance and scheduled endpoints #88 #96

merged 32 commits into from
Jul 3, 2024

Conversation

MatteoGuarnaccia5
Copy link
Contributor

Description

Added /maintenance and /scheduled_maintenance endpoints, both of which return a schema from a file that is manually editable

Testing instructions

  • Review code
  • Check Actions build

Agile board tracking

closes #88

@MatteoGuarnaccia5
Copy link
Contributor Author

Only thing left is the scigateway changes, and the ReadMe instructions - which I am not 100% how to do

@joelvdavies joelvdavies mentioned this pull request Jun 21, 2024
Merged
3 tasks
VKTB
VKTB reviewed Jun 21, 2024
View reviewed changes
README.md Show resolved Hide resolved
ldap_jwt_auth/core/exceptions.py Show resolved Hide resolved
ldap_jwt_auth/core/exceptions.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/exceptions.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/exceptions.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/exceptions.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/schemas.py Outdated Show resolved Hide resolved
joelvdavies
joelvdavies reviewed Jun 24, 2024
View reviewed changes
README.md Show resolved Hide resolved
joelvdavies
joelvdavies approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for me on ral-facilities/scigateway#1398. Should be merged at the same time as that and the docker-ims MR.

VKTB
VKTB requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@VKTB VKTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things, otherwise looks good.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ldap_jwt_auth/core/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/core/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/routers/maintenance.py Outdated Show resolved Hide resolved
ldap_jwt_auth/routers/maintenance.py Outdated Show resolved Hide resolved
test/unit/maintenance/test_maintenance.py Show resolved Hide resolved
VKTB
VKTB requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@VKTB VKTB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final couple of minor things. Could you please also run black --line-length 120 ldap_jwt_auth test and commit the changes?

README.md Outdated Show resolved Hide resolved
test/unit/maintenance/test_maintenance.py Outdated Show resolved Hide resolved
@MatteoGuarnaccia5 MatteoGuarnaccia5 requested a review from VKTB July 2, 2024 07:17
@VKTB
Copy link
Collaborator

VKTB commented Jul 2, 2024

Squash and merge this one when ready to be merged.

joelvdavies
joelvdavies approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again should be merged at the same time as the SciGateway & docker-ims PR/MR.

@VKTB VKTB merged commit 15b4ca2 into main Jul 3, 2024
5 checks passed
@VKTB VKTB deleted the add-maintenance-and-scheduled-endpoints-#88 branch July 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelvdavies joelvdavies joelvdavies approved these changes

@VKTB VKTB VKTB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add maintenance and scheduled_maintenance endpoints
3 participants
@MatteoGuarnaccia5 @VKTB @joelvdavies