Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ICAT user's investigation and instrument IDs in JWT access token #137

Open
wants to merge 7 commits into
base: port-over-to-fastapi-#133
Choose a base branch
from

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Dec 12, 2024

Description

Updates the app so that it queries ICAT for the user’s Investigations (as an InvestigationUser) AND Instruments (as an InstrumentScientist). It also updates the JWT access token payload so that these, which are need by the Search API component, are included.

Testing Instructions

  • Review code
  • Check GitHub Actions build
  • Review changes to test coverage

Agile Board Tracking

closes #136

@VKTB VKTB linked an issue Dec 12, 2024 that may be closed by this pull request
1 task
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that it's working okay with SciGateway - even with autoLogin mode (aka an anon authenticator set up) the behaviour seems to not have changed due to the change in error codes in some circumstances (tested both the 401 errors and 500)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ICAT user's investigation and instrument IDs in JWT access token
2 participants