Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests #201

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Improve unit tests #201

merged 2 commits into from
Jun 10, 2024

Conversation

chrhansk
Copy link
Contributor

@chrhansk chrhansk commented Jun 9, 2024

There are as of currently some inconveniences with regards to the built-in unit tests:

  • First, the tests are installed, which goes against conventions: Either people help to develop the package using the existing source, or they want to use the library / drivers after install. In either case, the tests are not required to be installed.
  • Second, the unit tests don't pass unless certain OMP-related environment variables are set. If these variables are set via meson, then this problem disappears and the tests always pass.

@jfowkes jfowkes self-requested a review June 10, 2024 12:32
Copy link
Contributor

@jfowkes jfowkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, many thanks!

@jfowkes jfowkes merged commit b504b46 into ralna:master Jun 10, 2024
16 checks passed
@amontoison
Copy link
Member

I was not aware that it was possible to pass environment variables to Meson like this.
Thanks for the tip, @chrhansk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants