refactor(highlights): use custom highlight groups #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue shouldn't be possible, but there seems to be some optimization going on that sometimes removes empty tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom highlight groups allow for highlight modules to share common highlight groups that are not defined by neovim.
As a consequence of introducing them, some highlights were revisited and modified slightly, either to share one common style, or simply adhere a little bit better to colorscheme's vision. Most notably, the menu buttons were changed to have a more minimal style.
There might some highlights I've missed, that could use custom highlight groups. With future PRs, they should be refactored to use custom highlight groups.