feat(highlights): add fzf-lua #79
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| local M = {} | ||
|
|
||
| function M.set(hl, colors) | ||
| hl.set("FzfLuaNormal", { bg = colors.dark_bg, fg = colors.fg3 }) | ||
| hl.set("FzfLuaBorder", { bg = colors.dark_bg, fg = colors.dark_bg }) | ||
| hl.set("FzfLuaTitle", { fg = hl.get("Normal").fg }) | ||
| hl.set("FzfLuaPreviewNormal", { bg = hl.get("Normal").bg, fg = hl.get("Normal").fg }) | ||
| hl.set("FzfLuaPreviewBorder", { bg = hl.get("Normal").bg, fg = hl.get("Normal").bg }) | ||
| hl.set("FzfLuaPreviewTitle", { link = "FzfLuaTitle" }) | ||
| hl.set("FzfLuaCursorLine", { bg = colors.bg2, fg = colors.fg2 }) | ||
|
There was a problem hiding this comment. Here I would suggest: ( local groups = require("mellifluous.highlights.custom_groups").get(colors)
hl.set("FzfLuaCursorLine", { bg = groups.MenuButtonSelected(normal.bg).bg, fg = normal.fg })I don't think there's any reason to have lighter There was a problem hiding this comment. Oh, apparently, |
||
| hl.set("FzfLuaScrollBorderFull", { fg = colors.bg4 }) | ||
| hl.set("FzfLuaScrollBorderEmpty", { fg = colors.bg }) | ||
| hl.set("FzfLuaScrollFloatFull", { link = "FzfLuaScrollBorderFull" }) | ||
| hl.set("FzfLuaScrollFloatEmpty", { link = "FzfLuaScrollBorderEmpty" }) | ||
| hl.set("FzfLuaHeaderBind", { fg = colors.ui_purple }) | ||
| hl.set("FzfLuaHeaderText", { fg = colors.fg4 }) | ||
|
There was a problem hiding this comment. This group goes nicely here: hl.set("FzfLuaFzfHeader", { fg = colors.fg4 }) |
||
| hl.set("FzfLuaPathLineNr", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaPathColNr", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaBufName", { fg = colors.ui_orange }) | ||
| hl.set("FzfLuaBufNr", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaBufFlagCur", { fg = colors.ui_purple }) | ||
| hl.set("FzfLuaBufFlagAlt", { fg = colors.ui_green }) | ||
| hl.set("FzfLuaTabTitle", { link = "FzfLuaTitle" }) | ||
| hl.set("FzfLuaTabMarker", { fg = colors.ui_purple }) | ||
| hl.set("FzfLuaLiveSym", { fg = colors.fg }) | ||
| hl.set("FzfLuaFzfMatch", { fg = colors.fg }) | ||
| hl.set("FzfLuaFzfScrollbar", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaFzfSeparator", { fg = colors.dark_bg }) | ||
| hl.set("FzfLuaFzfGutter", { bg = colors.dark_bg }) | ||
| hl.set("FzfLuaFzfPointer", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaFzfMarker", { fg = colors.ui_orange }) | ||
| hl.set("FzfLuaFzfPrompt", { fg = colors.fg4 }) | ||
| hl.set("FzfLuaFzfQuery", { fg = colors.fg }) | ||
| end | ||
|
|
||
| return M | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no easy way to change normal
bgor previewbgwithout changing a whole lot of highlight groups manually.I think it's okay to use some variables for highlights as long as it offers readability and/or maintainability improvements. Here we could have a variable
normalforFzfLuaNormal, this variable could then be reused in other highlight groups. Similarly we could have a variablepreview_normal.A fine alternative would be to reuse
FzfLuaNormalandFzfLuaPreviewNormalwith linking andhl.getfunction.