Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InstallCodeMirror export #11962

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

jordojordo
Copy link
Member

Summary

When running an extension locally in the dev environment with the latest Vue3 changes that uses the CodeMirror plugin, you will get an warning in the console:

 warning  in ./node_modules/@rancher/shell/initialize/install-plugins.js

export 'InstallCodemirro' (imported as 'InstallCodemirro') was not found in 'codemirror-editor-vue3' (possible exports: CodeMirror, GlobalCmComponent, InstallCodeMirror, VueCodemirror, createLinkMark, createLog, createLogMark, createTitle, default, getLinkMarks, getLocalTime, getLogMark, logErrorType)

Occurred changes and/or fixed issues

This fixes the import and export for InstallCodeMirror.

Technical notes summary

Areas or cases that should be tested

An extension using the CodeMirror plugin.

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@jordojordo jordojordo added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Sep 18, 2024
@jordojordo jordojordo added this to the v2.10.0 milestone Sep 18, 2024
@jordojordo jordojordo self-assigned this Sep 18, 2024
@jordojordo jordojordo marked this pull request as ready for review September 18, 2024 16:33
@jordojordo jordojordo merged commit d393508 into rancher:master Sep 18, 2024
30 checks passed
@jordojordo jordojordo deleted the install-code-mirror branch September 18, 2024 22:54
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
* Fix InstallCodeMirror export

* Bumping/pinning the version of codemirror-editor-vue3

---------

Co-authored-by: Cody Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants