Chore/url for origin #12621
Draft
Chore/url for origin #12621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are instances where Steve can provide the url of the API server for content links (e.g. `http://127.0.0.1:9443/v1/management.cattle.io.clusters`); this can prove to be problematic if the URL for Steve and the frontend server differ, resulting in CORS errors when Dashboard attempts to communicate with Steve directly. By stripping the origin from the URL, we can ensure that uses the correct base url and always routes API traffic through a proxy. Signed-off-by: Phillip Rak <[email protected]>
`URL.canParse()` is newly available as of December 2023 and might not work in older devices or browsers. We can use this utility function until we target a version of ecmascript/node that will reliably support `URL.canParse()` across all browsers and devices. Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
rak-phillip
force-pushed
the
chore/url-for-origin
branch
from
26f5949
to
3fb53be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist