Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with display of fleet and cattle agent status on cluster da… #12717

Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Nov 29, 2024

Forward port of PR #12710

Summary

Fixes #12680

Occurred changes and/or fixed issues

Technical notes summary

  • The View Monitoring custom role allows for the user to have access to the namespaces that were the condition to display the boxes, but the user didn't have permissions to view Deployments and Statefulsets which are the resources that hold the status information

Areas or cases that should be tested

Repro steps as per #12680 (comment)

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…shboard view with very limited user permissions
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.1 milestone Nov 29, 2024
@aalves08 aalves08 modified the milestones: v2.10.1, v2.11.0 Nov 29, 2024
@aalves08 aalves08 requested review from mantis-toboggan-md and torchiaf and removed request for mantis-toboggan-md November 29, 2024 10:10
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 6bc972a into rancher:master Nov 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants