Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10.1] Fixed drain worker form being uneditable #12870

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Dec 11, 2024

Summary

Fixes #12673

DrainNode dialog didn't get updated correctly as part of Vue 3 migration

Areas or cases that should be tested

Downstream cluster -> Nodes -> Drain dialog
Input elements should be editable.
After saving, request should contain correct data that matches edited configuration

Areas which could experience regressions

None

Screenshot/Video

Screen.Recording.2024-12-11.at.11.26.05.AM.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich eva-vashkevich added this to the v2.10.1 milestone Dec 11, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.1 milestone Dec 11, 2024
@eva-vashkevich eva-vashkevich changed the title [FIX] Fixed drain worker form being uneditable [2.10.1] Fixed drain worker form being uneditable Dec 11, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should investigate to find other areas that might have been omitted in the migration

@eva-vashkevich
Copy link
Member Author

LGTM - we should investigate to find other areas that might have been omitted in the migration

I've checked and all other Radio Buttons look good, but there are a few other places that use v-model in a way that looks sketchy to me

@rak-phillip
Copy link
Member

I've checked and all other Radio Buttons look good, but there are a few other places that use v-model in a way that looks sketchy to me

Can we create an issue to follow-up and investigate?

@eva-vashkevich eva-vashkevich merged commit 5218335 into rancher:release-2.10 Dec 11, 2024
34 checks passed
@eva-vashkevich eva-vashkevich deleted the iss12632-2.10 branch December 11, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants