-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide AKS, EKS, and GKE cards when their kontainer drivers are deactivated #12903
Hide AKS, EKS, and GKE cards when their kontainer drivers are deactivated #12903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left three comments to be resolved, though none are blocking this from merging and can be tracked in issues for later.
let me know if you'd like me to do / split between us some of the nit picky ones!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, #12925 should fix the failing storybook gate. Once that merges this just needs a rebase and can go in.
@mantis-toboggan-md Given backports might also be affected I'd be ok with cherry-picking the commit from that PR and included it in the backport PRs. Does that sound ok your side?
…getter to eks, aks, and gke provisioners to hide them when the kontainer driver is inactive
- make the top spacing small (given it's not seperating between rows) - add e2e test in - tweaked the get (added `/`, worked ok without for me though) - check whole row cluster driver row is missing
2ef539c
to
29abba5
Compare
Summary
Fixes #12898
Occurred changes and/or fixed issues
This PR updates the AKS, EKS, and GKE ui extensions to hide their respective cluster creation cards when their kontainer driver is deactivated.
Technical notes summary
The PR changes the behavior of the
disabled
property of the ClusterProvisioner class so that it aligns with what happens when a node/kontainer driver with custom ui is deactivated. Rather than showing disabled cards the cards are gone entirely.Areas or cases that should be tested
Checklist