Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide AKS, EKS, and GKE cards when their kontainer drivers are deactivated #12903

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #12898

Occurred changes and/or fixed issues

This PR updates the AKS, EKS, and GKE ui extensions to hide their respective cluster creation cards when their kontainer driver is deactivated.

Technical notes summary

The PR changes the behavior of the disabled property of the ClusterProvisioner class so that it aligns with what happens when a node/kontainer driver with custom ui is deactivated. Rather than showing disabled cards the cards are gone entirely.

Areas or cases that should be tested

  • disable aks, eks, gke kontainer drivers and verify that the associated card is gone from the cluster creation page after each is disabled
  • re-enable those providers and verify that the cards are back
  • verify that clicking the cards loads the newer vue ui

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

cypress/e2e/tests/pages/manager/cluster-manager.spec.ts Outdated Show resolved Hide resolved
shell/core/types-provisioning.ts Outdated Show resolved Hide resolved
richard-cox
richard-cox previously approved these changes Dec 19, 2024
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left three comments to be resolved, though none are blocking this from merging and can be tracked in issues for later.

let me know if you'd like me to do / split between us some of the nit picky ones!

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, #12925 should fix the failing storybook gate. Once that merges this just needs a rebase and can go in.

@mantis-toboggan-md Given backports might also be affected I'd be ok with cherry-picking the commit from that PR and included it in the backport PRs. Does that sound ok your side?

mantis-toboggan-md and others added 7 commits December 20, 2024 12:37
…getter to eks, aks, and gke provisioners to hide them when the kontainer driver is inactive
- make the top spacing small (given it's not seperating between rows)
- add e2e test in
  - tweaked the get (added `/`, worked ok without for me though)
  - check whole row cluster driver row is missing
@richard-cox richard-cox merged commit 425ea03 into rancher:master Dec 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable new hosted provider extensions
3 participants