-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix keyboard nav for home page #12966
Open
aalves08
wants to merge
7
commits into
rancher:master
Choose a base branch
from
aalves08:12776-fix-keyboard-nav-home-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix keyboard nav for home page #12966
aalves08
wants to merge
7
commits into
rancher:master
from
aalves08:12776-fix-keyboard-nav-home-page
+126
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalves08
force-pushed
the
12776-fix-keyboard-nav-home-page
branch
from
January 3, 2025 12:30
ae607b8
to
50c9515
Compare
22 tasks
rak-phillip
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think all the comments I left are fairly minor and have been addressed in other open accessibility PRs.
pkg/rancher-components/src/components/Form/Checkbox/Checkbox.vue
Outdated
Show resolved
Hide resolved
aalves08
force-pushed
the
12776-fix-keyboard-nav-home-page
branch
from
January 6, 2025 19:04
7da65a7
to
f7a177e
Compare
rak-phillip
reviewed
Jan 6, 2025
aalves08
force-pushed
the
12776-fix-keyboard-nav-home-page
branch
from
January 7, 2025 10:01
072c566
to
4a2d31c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12776
Occurred changes and/or fixed issues
home
pageBanner
component has correct roles, labels and is focusableSortableTable
component has been fixed for basic keyboard nav (sorting, checkboxes, links, open/close row action menu)Technical notes summary
Areas or cases that should be tested
home
page and browse the page with the tab keyenter
orspace
key to trigger UI elements on the pageAreas which could experience regressions
Screenshot/Video
Screen.Recording.2025-01-02.at.16.23.48.mov
Checklist