Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting unwanted manual setup instructions #3984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

divya-mohan0209
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 commented Mar 28, 2022

@@ -124,26 +124,9 @@ For this example, we are going to use [Prometheus](https://prometheus.io/). We a

Prometheus is available for deployment in the Rancher v2.0 catalog. Deploy it from Rancher catalog if it isn't already running in your cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should refer to the installation of the rancher-monitoring chart instead and link to the Monitoring docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axeal , while I'm happy to make the changes I think it would be good creating another section for the rancher-monitoring chart because this section is explicitly detailing using third-party tools such as Prometheus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axeal : Gentle reminder on the above, please could you let me know your response?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-mohan0209 This section (https://github.com/rancher/docs/blob/b4f4bfb8cdcfd38bbaad86e1838d00a8933dd52f/content/rancher/v2.x/en/k8s-in-rancher/horitzontal-pod-autoscaler/_index.md) pre-dates the Rancher v2.2 release (https://github.com/rancher/rancher/releases/v2.2.0) that introduced monitoring as a feature into Rancher v2. With monitoring, including prometheus and prometheus-adapter, available as a feature out-of-the-box, documentation on installing a custom prometheus adapter instance for a custom Prometheus deployment do not seem relevant anymore.

@@ -121,26 +121,9 @@ For this example, we are going to use [Prometheus](https://prometheus.io/). We a

Prometheus is available for deployment in the Rancher v2.0 catalog. Deploy it from Rancher catalog if it isn't already running in your cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for v2.5: "I think we should refer to the installation of the rancher-monitoring chart instead and link to the Monitoring docs."

@catherineluse catherineluse removed their request for review June 27, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rancher2] Remove redundant instructions on installation of k8s-prometheus-adapter from HPA docs
3 participants