[feature] Rancher UI dashboard commands #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
requested changes
Sep 3, 2024
tashima42
reviewed
Sep 3, 2024
rafaelbreno
force-pushed
the
feature/rancher-ui-dashboard
branch
from
cd5900c
to
453d7b5
Compare
briandowns
reviewed
Sep 4, 2024
nicholasSUSE
reviewed
Sep 4, 2024
rafaelbreno
force-pushed
the
feature/rancher-ui-dashboard
branch
from
578e465
to
2e8c050
Compare
tashima42
requested changes
Oct 3, 2024
tashima42
reviewed
Oct 3, 2024
tashima42
reviewed
Oct 3, 2024
tashima42
requested changes
Oct 11, 2024
rafaelbreno
force-pushed
the
feature/rancher-ui-dashboard
branch
from
9cf135a
to
ac7637e
Compare
briandowns
approved these changes
Oct 15, 2024
tashima42
reviewed
Oct 15, 2024
Comment on lines
+349
to
+368
| func genUIReleaseNotes(tmpl *template.Template, _ string, rd uiReleaseNoteData) (*bytes.Buffer, error) { | ||
| uiTemplate := fmt.Sprintf(dashboardReleaseNoteTemplate, "ui") | ||
| tmpl = template.Must(tmpl.Parse(uiTemplate)) | ||
| b := bytes.NewBuffer(nil) | ||
| if err := tmpl.ExecuteTemplate(b, uiRepo, rd); err != nil { | ||
| return nil, err | ||
| } | ||
| return b, nil | ||
| } | ||
|
|
||
| func genDashboardReleaseNotes(tmpl *template.Template, _ string, rd dashboardReleaseNoteData) (*bytes.Buffer, error) { | ||
| dashboardTemplate := fmt.Sprintf(dashboardReleaseNoteTemplate, "dashboard") | ||
| tmpl = template.Must(tmpl.Parse(dashboardTemplate)) | ||
| b := bytes.NewBuffer(nil) | ||
| if err := tmpl.ExecuteTemplate(b, dashboardRepo, rd); err != nil { | ||
| return nil, err | ||
| } | ||
| return b, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Not saying that we should do it, but I think this is a case where we could use the new go generics
tashima42
approved these changes
Oct 15, 2024
nicholasSUSE
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands added
$ release [repo] release-notesAdded support for
repo:uidashboardCommand examples:
$ release generate ui release-notes --milestone v2.9.1 --prev-milestone v2.9.0$ release generate dashboard release-notes --milestone v2.9.1 --prev-milestone v2.9.0This command will generate and output the release notes, based on two milestones.
$ release [repo] [ga,ra] [version]Added support for
repo:uidashboard$ release tag dashboard rc v2.9.1tags https://github.com/rafaelbreno/rancher-dashboard/releases/tag/v2.9.1-rc1$ release tag dashboard ga v2.9.1tags https://github.com/rafaelbreno/rancher-dashboard/releases/tag/v2.9.0$ release update rancher dashboard [version]This command is ran in the
rancher/rancherfork clone, where it will run a script that updates the two necessary fields, and opens a PR againstrancher/rancher.Command examples:
$ release update rancher dashboard v2.9.1-rc8opens Bump Dashboard tov2.9.1-rc8rancher#46947