Wrap mount.Interface to our own interface #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
commented
Dec 11, 2023
| type Mounter interface { | ||
| Mount(source string, target string, fstype string, options []string) error | ||
| Unmount(target string) error | ||
| IsLikelyNotMountPoint(file string) (bool, error) |
There was a problem hiding this comment.
This is the actual mounter interface we really need and the only place where we import the actual third party implementation.
Indeed it should be relatively simple to use another implementation, we could even provide our own in order to reduce third party dependencies.
davidcassany
force-pushed
the
mounter_interface
branch
from
4db35b3
to
a636ec3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 75.96% 72.47% -3.50%
==========================================
Files 66 69 +3
Lines 6912 7274 +362
==========================================
+ Hits 5251 5272 +21
- Misses 1290 1624 +334
- Partials 371 378 +7 ☔ View full report in Codecov by Sentry. |
davidcassany
force-pushed
the
mounter_interface
branch
from
a636ec3
to
4760132
Compare
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
mounter_interface
branch
from
4760132
to
99367c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the actual mount interface we need in elemental and wraps
k8s.io/mount-utilsuse in a single place. This makes our mounter interface way easier to substitute by another implementation if needed at some point. It also makes evident we need a simple mount interface.Part of #1874