Refactor some elemental package methods to be used as stand alone functions #1883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some methods in elemental package. Basically it turns some of the methods in to static functions not tied to any object.
This is to allow reusing them without the need of an Elemental object. In fact I am also wondering of running a follow up PR completely removing the Elemental object from
elemental-toolkit/pkg/elemental/elemental.go
Lines 33 to 35 in a7b7f2e
as this is a useless object. In only keeps the configuration which is anyway already available in all places where the elemental package is in use. So in a follow up PR I would even consider dropping the object entirely and simply pass the configuration struct as a parameter.
Part of #1874