Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to cleanup-cache workflow #1887

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Dec 14, 2023

Tested this in https://github.com/frelon/cache-test/actions/runs/7209527181/job/19640659692 and seems to work when permissions are added for the whole workflow and not only jobs.

Signed-off-by: Fredrik Lönnegren <[email protected]>
@frelon frelon requested a review from a team as a code owner December 14, 2023 13:28
@frelon frelon enabled auto-merge (squash) December 14, 2023 13:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a6223) 73.60% compared to head (93aafb1) 73.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1887   +/-   ##
=======================================
  Coverage   73.60%   73.60%           
=======================================
  Files          69       69           
  Lines        7332     7332           
=======================================
  Hits         5397     5397           
  Misses       1544     1544           
  Partials      391      391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frelon frelon merged commit 6f259ee into rancher:main Dec 14, 2023
14 checks passed
@frelon frelon deleted the cache-cleanup2 branch December 14, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants