Improved upgrade test

[frelon]

The upgrade test will now prepare a VM with an older (v1.1.4) version and then run the upgrade in podman to upgrade to the current PR container.

This will make sure we can upgrade from v1.1.4 to current and also that the correct version of the upgrade command is tested (the new one, not the old installed one).

Fixes #1928

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc53c13) 72.04% compared to head (3998242) 72.04%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1960   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          72       72           
  Lines        8019     8019           
=======================================
  Hits         5777     5777           
  Misses       1779     1779           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[frelon]

Got a green upgrade run at https://github.com/rancher/elemental-toolkit/actions/runs/7917180349/job/21613080610?pr=1960 going back to pull_request_target event.

[davidcassany]

I am a bit lost with these changes... Shouldn't it be a new test, so we test both directions:

1. from current head downgrade to a names tag/version
2. from a named/tag version upgrade to current head

1 is what we already had, we are missing 2.

I guess this also apply to the recovery tests which in fact is just an upgrade test executed from recovery system.

[frelon]

I am a bit lost with these changes... Shouldn't it be a new test, so we test both directions:

1. from current head downgrade to a names tag/version

2. from a named/tag version upgrade to current head

1 is what we already had, we are missing 2.

I guess this also apply to the recovery tests which in fact is just an upgrade test executed from recovery system.

I can add back the old upgrade test and call it downgrade instead, then we get both tests named correctly 👍

[davidcassany]

Nice! LGTM 👍