Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding snapshotter.type flag install command #1987

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany requested a review from a team as a code owner March 1, 2024 09:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 72.56%. Comparing base (e56244d) to head (361b2c0).

Files Patch % Lines
pkg/types/v1/snapshotter.go 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
+ Coverage   72.50%   72.56%   +0.05%     
==========================================
  Files          76       76              
  Lines        8883     8894      +11     
==========================================
+ Hits         6441     6454      +13     
+ Misses       1910     1907       -3     
- Partials      532      533       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidcassany davidcassany merged commit bdb073a into rancher:main Mar 4, 2024
17 of 19 checks passed
@davidcassany davidcassany deleted the add_snapshotter_type_flag branch March 4, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants