RISC-V improvements + fixes #2235
Conversation
Without this we always have the host architecture instead of the platform one in cross-compilation. Signed-off-by: Loic Devulder <[email protected]>
Still not enabled by default, but could be added like any other features. Signed-off-by: Loic Devulder <[email protected]>
Signed-off-by: Loic Devulder <[email protected]>
Signed-off-by: Loic Devulder <[email protected]>
ldevulder
force-pushed
the
fix-riscv-support
branch
from
89b3056
to
4690de6
Compare
| ADD_FEATURES+=" grub-default-bootargs"; \ | ||
| [[ "${ARCH}" == "aarch64" ]] && ADD_FEATURES+=" arm-firmware"; \ | ||
| fi; \ | ||
| elemental --debug init --force \ |
There was a problem hiding this comment.
I think we should keep the default features here since these are what's tested in the CI.
There was a problem hiding this comment.
What do you mean? The code will keep the defaults for x86 (yes explicitly written) and only change for arm64 (adding arm-firmware) and riscv64 because this one needs specific Grub options.
There was a problem hiding this comment.
Yes, but we want to test that the default features added through the implicit case works (also autologin is not one of the default features)
There was a problem hiding this comment.
In that case I will have to either use a dedicated Dockerfile or defined the list of features only for riscv64 (and arm64 maybe?) and keep the default for x86.
WDYT is the better way for you? I first tried to avoid a pretty much full copy/paste of the Dockerfile only for riscv64, but if you think that an easier way to do it
that's fine.
This PR contains some RISC-V support improvement and fixes for small issues I found: