Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from github.com/golang/mock to go.uber.org/mock #100

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Switch from github.com/golang/mock to go.uber.org/mock #100

merged 5 commits into from
Sep 11, 2024

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Sep 5, 2024 •
edited
Loading

Issue: rancher/rancher#46972

  • Adds missing go:generate, so all code can now be generated running go generate ./...
  • Refresh generated files
  • Update imports to the new dependency.
  • go mod tidy

@aruiz14 aruiz14 requested a review from a team as a code owner September 5, 2024 15:44
ericpromislow
ericpromislow previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I especially like the way the uber version writes out the command in generated files that was used to generate them.

@aruiz14
Copy link
Contributor Author

aruiz14 commented Sep 6, 2024

Thanks @ericpromislow, would you mind also taking a look at the equivalent PR in wrangler?

@prachidamle prachidamle requested a review from a team September 10, 2024 18:44
moio
moio previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@moio moio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to a maintained version is a good thing (tm)

approved

@aruiz14 aruiz14 dismissed stale reviews from moio and ericpromislow via c47b8b4 September 11, 2024 07:35
ericpromislow
ericpromislow approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good after this last change

@MbolotSuse MbolotSuse merged commit 6b2576c into rancher:master Sep 11, 2024
1 check passed
@moio moio mentioned this pull request Oct 1, 2024
Merged
moio added a commit to moio/rancher that referenced this pull request Oct 2, 2024
@moio
Bump lasso
5317933 
This includes various fixes to the UI Server-Side Pagination experimental
feature:

https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination

- rancher/lasso#86
- rancher/lasso#90
- rancher/lasso#85
- rancher/lasso#92
- rancher/lasso#79
- rancher/lasso#97
- rancher/lasso#94
- rancher/lasso#98
- rancher/lasso#108
- rancher/lasso#99

It also includes improvements to code collecting metrics:
- rancher/lasso#89
- rancher/lasso#95

And to test code:
- rancher/lasso#100
- rancher/lasso#101

Signed-off-by: Silvio Moioli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moio moio moio approved these changes

@ericpromislow ericpromislow ericpromislow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aruiz14 @ericpromislow @moio @MbolotSuse