sql: silence informer errors on unwatchable resources #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listable-but-unwatchable resources such as nodes metrics.k8s.io/v1beta1 allow an Informer to be started, but it will by default log all watch failures. Add a boolean flag to silence those errors. Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
|
Looks ok, but how is the calling code in |
|
Yes, we have a method for that in Steve https://github.com/rancher/steve/blob/ea177193f12ade5f64ac4ef58354a629329da9e2/pkg/controllers/schema/schemas.go#L111 This PR actually supports a sister Steve PR rancher/steve#284 |
tomleb
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listable-but-unwatchable resources such as
nodes metrics.k8s.io/v1beta1allow an Informer to be started, but it will by default log all watch failures.Add a boolean flag to silence those errors.
partially addresses rancher/rancher#46030
supports rancher/steve#284
best reviewed commit-by-commit