Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file permissions on the sqlite db. #116

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

bigkevmcd
Copy link
Contributor

@bigkevmcd bigkevmcd commented Nov 1, 2024

This ensures that the permissions on the file that SQLite is using are correct (0600) i.e. user read/write.

Part of rancher/rancher#47825

@bigkevmcd bigkevmcd requested a review from a team as a code owner November 1, 2024 09:53
@bigkevmcd bigkevmcd requested review from moio and pjbgf and removed request for a team November 1, 2024 09:58
@bigkevmcd
Copy link
Contributor Author

This fixes the primary object cache, but I'm not sure where the other resources are stored.

pkg/cache/sql/db/client.go Outdated Show resolved Hide resolved
This ensures that the permissions on the file that SQLite is using are
correct (0600) i.e. user read/write.
@bigkevmcd bigkevmcd force-pushed the set-file-permissions-on-sqlite branch from c16b2c8 to 3c49d3d Compare November 1, 2024 10:34
@bigkevmcd bigkevmcd requested a review from pjbgf November 1, 2024 11:02
pkg/cache/sql/db/client.go Outdated Show resolved Hide resolved
bigkevmcd and others added 2 commits November 1, 2024 11:29
This ensures that when touchFile returns the referenced file will have
the correct permissions.
@tomleb tomleb requested a review from a team November 1, 2024 13:52
moio
moio previously approved these changes Nov 4, 2024
Copy link
Contributor

@moio moio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but I'd like the comment clarified.

moio
moio previously approved these changes Nov 5, 2024
@bigkevmcd
Copy link
Contributor Author

@ericpromislow Can you give this a 👍🏻 ?

@moio
Copy link
Contributor

moio commented Nov 12, 2024

@bigkevmcd please note this should target the main branch now, not master

@bigkevmcd bigkevmcd changed the base branch from master to main November 12, 2024 17:00
@bigkevmcd bigkevmcd dismissed moio’s stale review November 12, 2024 17:00

The base branch was changed.

Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG now

@moio moio merged commit d19dc78 into rancher:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants