🌱 chore: differentiate ghcr and prod registry workflows #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
changed the title
salasberryfin
force-pushed
the
split-image-push-workflows
branch
from
5a04fb3 to
0be4d4a
Compare
alexander-demicev
previously approved these changes
Oct 4, 2023
|
This needs a major rebase after adding SLSA signing. I'm changing it back to WIP. |
salasberryfin
changed the title
salasberryfin
force-pushed
the
split-image-push-workflows
branch
from
0be4d4a to
b838949
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
split-image-push-workflows
branch
from
b838949 to
d1354f2
Compare
salasberryfin
changed the title
|
The PR is now rebased and includes the SLSA signing feature merged last week, which is hopefully not affected by this. Additionally, added outputs for |
salasberryfin
requested review from
alexander-demicev,
richardcase,
Danil-Grigorev and
furkatgofurov7
furkatgofurov7
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current release workflow builds and publishes images to both GHCR and Prime registry. While creating the first Rancher Turtles release candidate we thought we could split these actions into different jobs for each registry.
This change also narrows the scope of environment variables to the specific jobs.
Which issue(s) this PR fixes:
Fixes #169
Special notes for your reviewer:
Checklist: