Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix agent node affinity settings to always prefer control plane nodes #433

Closed

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Mar 14, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev added the kind/bug Something isn't working label Mar 14, 2024
@richardcase
Copy link
Contributor

I think we need to hold off on this change for the following reasons:

  • We've not seen any issues in our testing specifically related to the scheduling/placement of the agent pod(s).
  • We don't have time to thoroughly test the impact of this before the release
  • We should consider fixing this upstream instead

@richardcase
Copy link
Contributor

richardcase commented Mar 15, 2024

Lets split out the helm addon and changing the tests to use calico instead of kindnet from the other changes.

@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev let's break this PR into two, the one with the changes @richardcase suggested and the latter we can go through in more detail.

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner March 21, 2024 11:31
Signed-off-by: Danil Grigorev <[email protected]>
Signed-off-by: Danil Grigorev <[email protected]>
@Danil-Grigorev
Copy link
Contributor Author

I’ll close this PR and open a separate one with calico changes only later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants