✨ Allow to perform manual ETCD snapshots #856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR completes the initial setup of the controller with functionality to create manual snapshots on user demand, using the
system-agent
and RKE2 cli, following the docs.This comes with some problems, like inability to specifically name the snapshot and deterministically connect it to the
ETCDMachineSnapshot
replica, created by the user, but the issue lays in lacking options ink3s/rke2
CLI. In the scenario when the snapshot is named “my-snapshot”, the actual name looks like:local-my-snapshot-rke2-control-plane-mnf8z-1731675906-31aa01
and may easily overlap with a snapshot named as just “snapshot”. (Edit: currently matches againstsnapshotName
andmachineName
)This also makes it hard to connect the
creationTimestamp
of the snapshot on the child cluster with the originally invokedETCDMachineSnapshot
resource execution, as no additional info can be stored on the snapshot instance when calling the CLI. (Edit: storing snapshot timestamp in the list now)Final snapshot location and other infor is created and is available on the list within the automatic snapshot record (one per cluster).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #725
Special notes for your reviewer:
Checklist: