✨ Populate fleet external annotation on management clusters #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
external-fleet-annotation
branch
2 times, most recently
from
8a4d1e3 to
74c7290
Compare
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
external-fleet-annotation
branch
from
74c7290 to
506b570
Compare
Co-authored-by: Alexander Demicev <[email protected]>
alexander-demicev
approved these changes
Dec 12, 2024
furkatgofurov7
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With introduction of rancher/rancher#46672
managementv3clusters annotated withprovisioning.cattle.io/externally-managedwill omit creating fleet cluster automatically with the instance. This allowsCAAPFto fully manage fleet cluster lifecycle workflow, which will no longer be duplicated.This PR allows to gauge the setting under the
addon-provider-fleetfeature gate.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: