🌱 Remove retry usages across the code #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
changed the title
anmazzotti
previously approved these changes
Dec 10, 2024
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
remove-retry
branch
from
4d96af2 to
ca05477
Compare
alexander-demicev
previously approved these changes
Dec 12, 2024
furkatgofurov7
approved these changes
Dec 12, 2024
alexander-demicev
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change remove usages of retry from the code, which improves situation with stuck tests on general timeout in local and CI runs. The object which is retried with patch is using
MergeFromWithOptimisticLockand the object is never updated, so this retry will never succeed.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #912
Special notes for your reviewer:
Checklist: