-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session manager in memory, addressing TODO. #3817
base: master
Are you sure you want to change the base?
Conversation
a1270b5
to
5d8186b
Compare
e4506a0
to
96d7c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that iOS and Android were updated a while ago, perhaps we might try and get our feet wet with ranges here. Also that might actually improve readability.
ok giving a try.. |
does not seem to bring down performance.
96d7c12
to
774faa6
Compare
should we update the fuzzer's toolchain too ? |
Thanks for trying this! Could you elaborate a bit on "the issue with clang < 16", please? To me it looks like the ranges implementation simply wasn't ready for prime time, yet. If that's true, I feel, we should just avoid range operations altogether, unfortunately. We committed to supporting Clang 14 for Botan 3.x), if it's not ready for (some) ranges features, it's just better to not use it at all, in my opinion. 😭
@randombit do we even have a way of doing that in OSS-Fuzz? |
Yes if you choose clang 14 as minimum I m afraid we can't indeed, clang is behind gcc, on average, in term of C++20 support. |
does not seem to bring down performance.