-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faster reduction for secp256k1 pcurves #4113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/faster-k1-redc
branch
from
June 11, 2024 12:09
b89ed62
to
4cd489f
Compare
randombit
force-pushed
the
jack/faster-k1-redc
branch
from
June 14, 2024 21:29
5815410
to
c33c00f
Compare
randombit
force-pushed
the
jack/faster-k1-redc
branch
from
June 14, 2024 22:39
c33c00f
to
efdbdc8
Compare
20 tasks
randombit
force-pushed
the
jack/faster-k1-redc
branch
from
July 9, 2024 00:55
efdbdc8
to
ed73a18
Compare
This takes advantage of the modulus being near a power of 2. Performance improvement varies by CPU, compiler, and specific algorithm in use, but generally ranges between 10% to 20%.
randombit
force-pushed
the
jack/faster-k1-redc
branch
from
July 10, 2024 10:52
ed73a18
to
ac87424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of the modulus being near a power of 2.
Rough idea of improvements. Seems to vary a lot between compilers and CPUs:
#4027