Add CT::Choice::yes() and ::no() #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
reviewed
Jun 27, 2024
src/lib/utils/ct_utils.h
Outdated
| @@ -134,6 +135,10 @@ class Choice final { | |||
| return Choice(ct_is_zero<uint32_t>(static_cast<uint32_t>(v_is_0))); | |||
| } | |||
|
|
|||
| constexpr static Choice yes() { return Choice::from_int(1U); } | |||
|
|
|||
| constexpr static Choice no() { return Choice::from_int(0U); } | |||
There was a problem hiding this comment.
These could just directly initialize the masked values (either all zero or all ones resp), no need for them to be guarded by the value barrier.
There was a problem hiding this comment.
Given that the constexpr-ness of the factory those delegate to, I was hoping that the compiler would do that for me and not actually compile a value barrier. But yeah, no harm in doing that explicitly.
There was a problem hiding this comment.
That would only apply if you created the variable as constexpr though, right?
constexpr auto yes = Choice::yes(); // compile time evaluated, no value barrier
const auto yes = Choice::yes(); // evaluted at runtime, presumably with value barrier
... to allow creating true/false choices (e.g. for unit testing)
reneme
force-pushed
the
rene/choice_factories
branch
from
3790e4d
to
d6b166b
Compare
|
BTW agree that we don't want/need any obvious conversion from |
randombit
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating a
CT::Choicerepresenting true or false (e.g. for unit testing). Also: restrictCT::Choice::from_int()to not work forboolas this produces compiler warnings* and is probably undesired (i.e. a code-smell) anyway. I need those for the requested adaptions tobitvector<>in #3107.[*] The compiler is complaining that we try to negate a bool using
~instead of!.