Improve performance on maps with many children #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! I've been meaning to try re.sub, but hadn't gotten around to it yet. If all the tests pass, this seems like an excellent fix! |
hugosandelius
force-pushed
the
improve-performance
branch
from
1bc2930 to
7f416ad
Compare
|
Looks like this is failing due to the pre-commit hook for Black formatting |
|
I force-pushed a fix for the formatting, the pre-commit hook should pass now. |
|
Super excited to try this out! |
|
@blackary Can you try to run these tests locally, or change the timeout of 30000ms? That's what keeps failing, the actual tests never even run |
|
I think some of the failures were literally because the playwright window was too small to see the map 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will significantly improve the running time of
st_foliumon maps with many children.In an example I tried with 10,336 child objects, the running time was improved from ~14 seconds to ~400 milliseconds.
Fixes #125