Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use render() in main only once #144

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Use render() in main only once #144

merged 1 commit into from
Sep 29, 2023

Conversation

BastienGauthier
Copy link
Contributor

This PR fixes #143
-> fig.render is removed in _get_map_string and _get_siblings to avoid redundancy.

Note : performance gain to have the map depicted on my use case (with st.profiler) : from 40sec to 25sec. (almost 40%)

@BastienGauthier
Use render() in main
fb0132d 
Removed in _get_map_string and _get_siblings
@blackary blackary self-requested a review September 29, 2023 16:50
blackary
blackary approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@blackary blackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much -- looks great!

@blackary blackary merged commit f4fdf46 into randyzwitch:master Sep 29, 2023
4 checks passed
@BastienGauthier BastienGauthier deleted the fix/multiple-render-use branch September 29, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackary blackary blackary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fig.render() is used several time in a row for st_folium
2 participants
@BastienGauthier @blackary